-
Notifications
You must be signed in to change notification settings - Fork 28
ci: add local pre-commit hook to write datasets.yaml #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
===========================================
+ Coverage 99.95% 100.00% +0.04%
===========================================
Files 92 93 +1
Lines 4026 4042 +16
Branches 714 715 +1
===========================================
+ Hits 4024 4042 +18
+ Misses 1 0 -1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
dkrako
commented
May 26, 2025
2cb43ae
to
ccad07e
Compare
15 tasks
SiQube
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building up on @SiQube's work in #914 this PR adds a pre-commit hook to autowrite the required
src/pymovements/datasets/datasets.yaml
.Implemented changes
write_datasets_yaml.py
including amain()
function.pre-commit-config.yaml
How Has This Been Tested?
Basic tests which compare the resulting
datasets.yaml
against the expected one:Context
related issues:
Checklist: